Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b86a5ccd authored by Xin Long's avatar Xin Long Committed by Greg Kroah-Hartman
Browse files

tipc: purge deferredq list for each grp member in tipc_group_delete 



[ Upstream commit 5cf02612b33f104fe1015b2dfaf1758ad3675588 ]

Syzbot reported a memleak caused by grp members' deferredq list not
purged when the grp is be deleted.

The issue occurs when more(msg_grp_bc_seqno(hdr), m->bc_rcv_nxt) in
tipc_group_filter_msg() and the skb will stay in deferredq.

So fix it by calling __skb_queue_purge for each member's deferredq
in tipc_group_delete() when a tipc sk leaves the grp.

Fixes: b87a5ea3 ("tipc: guarantee group unicast doesn't bypass group broadcast")
Reported-by: default avatar <syzbot+78fbe679c8ca8d264a8d@syzkaller.appspotmail.com>
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarYing Xue <ying.xue@windriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e1b0c311

net/tipc/group.c

+1 −0
Original line number Diff line number Diff line
@@ -218,6 +218,7 @@ void tipc_group_delete(struct net *net, struct tipc_group *grp) 


	rbtree_postorder_for_each_entry_safe(m, tmp, tree, tree_node) {

		tipc_group_proto_xmit(grp, m, GRP_LEAVE_MSG, &xmitq);

		__skb_queue_purge(&m->deferredq);

		list_del(&m->list);

		kfree(m);

	}