Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b7ef6f3c authored by Michael Ellerman's avatar Michael Ellerman Committed by Greg Kroah-Hartman
Browse files

powerpc/pseries: Fix node leak in update_lmb_associativity_index() 



[ Upstream commit 47918bc68b7427e961035949cc1501a864578a69 ]

In update_lmb_associativity_index() we lookup dr_node using
of_find_node_by_path() which takes a reference for us. In the
non-error case we forget to drop the reference. Note that
find_aa_index() does modify properties of the node, but doesn't need
an extra reference held once it's returned.

Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f4d1d649

arch/powerpc/platforms/pseries/hotplug-memory.c

+1 −0
Original line number Diff line number Diff line
@@ -202,6 +202,7 @@ static int update_lmb_associativity_index(struct drmem_lmb *lmb) 


	aa_index = find_aa_index(dr_node, ala_prop, lmb_assoc);



	of_node_put(dr_node);

	dlpar_free_cc_nodes(lmb_node);



	if (aa_index < 0) {