Commit b72987dd authored Jul 28, 2023 by Geert Uytterhoeven Committed by Greg Kroah-Hartman Sep 23, 2023

of: unittest: Fix overlay type in apply/revert check



[ Upstream commit 6becf8f845ae1f0b1cfed395bbeccbd23654162d ]

The removal check in of_unittest_apply_revert_overlay_check()
always uses the platform device overlay type, while it should use the
actual overlay type, as passed as a parameter to the function.

This has no impact on any current test, as all tests calling
of_unittest_apply_revert_overlay_check() use the platform device overlay
type.

Fixes: d5e75500 ("of: unitest: Add I2C overlay unit tests.")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/ba0234c41ba808f10112094f88792beeb6dbaedf.1690533838.git.geert+renesas@glider.be


Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1640c7bd

drivers/of/unittest.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1573,7 +1573,7 @@ static int __init of_unittest_apply_revert_overlay_check(int overlay_nr,
		}

		/* unittest device must be again in before state */
		if (of_unittest_device_exists(unittest_nr, PDEV_OVERLAY) != before) {
		if (of_unittest_device_exists(unittest_nr, ovtype) != before) {
		unittest(0, "%s with device @\"%s\" %s\n",
		overlay_name_from_nr(overlay_nr),
		unittest_path(unittest_nr, ovtype),