Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6e7aeea authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Felipe Balbi
Browse files

USB: gadgetfs: Fix a potential memory leak in 'dev_config()' 



'kbuf' is allocated just a few lines above using 'memdup_user()'.
If the 'if (dev->buf)' test fails, this memory is never released.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 42428202

drivers/usb/gadget/legacy/inode.c

+3 −1
Original line number Diff line number Diff line
@@ -1782,8 +1782,10 @@ dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) 


	spin_lock_irq (&dev->lock);

	value = -EINVAL;

	if (dev->buf)

	if (dev->buf) {

		kfree(kbuf);

		goto fail;

	}

	dev->buf = kbuf;



	/* full or low speed config */