Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6e6bca5 authored by Nikolay Borisov's avatar Nikolay Borisov Committed by David Sterba
Browse files

btrfs: qgroups: Fix BUG_ON condition in tree level check 



The current code was erroneously checking for
root_level > BTRFS_MAX_LEVEL. If we had a root_level of 8 then the check
won't trigger and we could potentially hit a buffer overflow. The
correct check should be root_level >= BTRFS_MAX_LEVEL .

Signed-off-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarQu Wenruo <quwenruo.btrfs@gmx.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent c5502451

fs/btrfs/qgroup.c

+1 −1
Original line number Diff line number Diff line
@@ -1603,7 +1603,7 @@ int btrfs_qgroup_trace_subtree(struct btrfs_trans_handle *trans, 
	struct extent_buffer *eb = root_eb;

	struct btrfs_path *path = NULL;



	BUG_ON(root_level < 0 || root_level > BTRFS_MAX_LEVEL);

	BUG_ON(root_level < 0 || root_level >= BTRFS_MAX_LEVEL);

	BUG_ON(root_eb == NULL);



	if (!test_bit(BTRFS_FS_QUOTA_ENABLED, &fs_info->flags))