Commit b6df5afc authored Oct 06, 2020 by Chaitanya Kulkarni Committed by Greg Kroah-Hartman Oct 14, 2020

nvme-core: put ctrl ref when module ref get fail



commit 4bab69093044ca81f394bd0780be1b71c5a4d308 upstream.

When try_module_get() fails in the nvme_dev_open() it returns without
releasing the ctrl reference which was taken earlier.

Put the ctrl reference which is taken before calling the
try_module_get() in the error return code path.

Fixes: 52a3974feb1a "nvme-core: get/put ctrl and transport module in nvme_dev_open/release()"
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 13e7ffa3

drivers/nvme/host/core.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2606,8 +2606,10 @@ static int nvme_dev_open(struct inode inode, struct file file)
		}

		nvme_get_ctrl(ctrl);
		if (!try_module_get(ctrl->ops->module))
		if (!try_module_get(ctrl->ops->module)) {
		nvme_put_ctrl(ctrl);
		return -EINVAL;
		}

		file->private_data = ctrl;
		return 0;