Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6b057d8 authored by David Kershner's avatar David Kershner Committed by Greg Kroah-Hartman
Browse files

staging: unisys: visorbus: remove bus_epilog 



Remove the function bus_epilog since no one is calling it.

Signed-off-by: default avatarDavid Kershner <david.kershner@unisys.com>
Reported-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: default avatarTim Sell <Timothy.Sell@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 33161a29

drivers/staging/unisys/visorbus/visorchipset.c

+2 −52
Original line number Original line Diff line number Diff line
@@ -688,56 +688,6 @@ device_responder(enum controlvm_id cmd_id, 
	controlvm_respond(pending_msg_hdr, response);

	controlvm_respond(pending_msg_hdr, response);

}

}





static void

bus_epilog(struct visor_device *bus_info,

	   u32 cmd, struct controlvm_message_header *msg_hdr,

	   int response, bool need_response)

{

	struct controlvm_message_header *pmsg_hdr = NULL;



	if (!bus_info) {

		/*

		 * relying on a valid passed in response code

		 * be lazy and re-use msg_hdr for this failure, is this ok??

		 */

		pmsg_hdr = msg_hdr;

		goto out_respond;

	}



	if (bus_info->pending_msg_hdr) {

		/* only non-NULL if dev is still waiting on a response */

		response = -CONTROLVM_RESP_ERROR_MESSAGE_ID_INVALID_FOR_CLIENT;

		pmsg_hdr = bus_info->pending_msg_hdr;

		goto out_respond;

	}



	if (need_response) {

		pmsg_hdr = kzalloc(sizeof(*pmsg_hdr), GFP_KERNEL);

		if (!pmsg_hdr) {

			POSTCODE_LINUX_4(MALLOC_FAILURE_PC, cmd,

					 bus_info->chipset_bus_no,

					 POSTCODE_SEVERITY_ERR);

			goto out_respond;

			return;

		}



		memcpy(pmsg_hdr, msg_hdr,

		       sizeof(struct controlvm_message_header));

		bus_info->pending_msg_hdr = pmsg_hdr;

	}



	if (response == CONTROLVM_RESP_SUCCESS) {

		switch (cmd) {

		default:

			goto out_respond;

		}

		return;

	}



out_respond:

	bus_responder(cmd, pmsg_hdr, response);

}



static void

static void

device_epilog(struct visor_device *dev_info,

device_epilog(struct visor_device *dev_info,

	      struct spar_segment_state state, u32 cmd,

	      struct spar_segment_state state, u32 cmd,
@@ -981,8 +931,8 @@ bus_configure(struct controlvm_message *inmsg, 
		POSTCODE_LINUX_3(BUS_CONFIGURE_EXIT_PC, bus_no,

		POSTCODE_LINUX_3(BUS_CONFIGURE_EXIT_PC, bus_no,

				 POSTCODE_SEVERITY_INFO);

				 POSTCODE_SEVERITY_INFO);

	}

	}

	bus_epilog(bus_info, CONTROLVM_BUS_CONFIGURE, &inmsg->hdr,

	if (inmsg->hdr.flags.response_expected == 1)

		   rc, inmsg->hdr.flags.response_expected == 1);

		bus_responder(inmsg->hdr.id, &inmsg->hdr, rc);

}

}





static void

static void