Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b681957a authored by Andrew Lunn's avatar Andrew Lunn Committed by David S. Miller
Browse files

dsa: mv88e6xxx: Initialise the mutex as soon as it is created



By initialising immediately it, we don't run the danger of using it
before it is initialised.

Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cb9b9020
Loading
Loading
Loading
Loading
+1 −2
Original line number Diff line number Diff line
@@ -3132,8 +3132,6 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)

	ps->ds = ds;

	mutex_init(&ps->smi_mutex);

	INIT_WORK(&ps->bridge_work, mv88e6xxx_bridge_work);

	if (mv88e6xxx_has(ps, MV88E6XXX_FLAG_EEPROM))
@@ -3580,6 +3578,7 @@ static const char *mv88e6xxx_probe(struct device *dsa_dev,
	ps->bus = bus;
	ps->sw_addr = sw_addr;
	ps->info = info;
	mutex_init(&ps->smi_mutex);

	*priv = ps;