Commit b6725b05 authored Feb 23, 2016 by Amitoj Kaur Chawla Committed by Greg Kroah-Hartman Mar 11, 2016

staging: netlogic: Simplify use of devm_ioremap_resource



Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to
devm_ioremap_resource.

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3765dc92

drivers/staging/netlogic/xlr_net.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -1038,13 +1038,6 @@ static int xlr_net_probe(struct platform_device *pdev)
		priv->port_id = (pdev->id * 4) + port;
		priv->nd = (struct xlr_net_data *)pdev->dev.platform_data;
		res = platform_get_resource(pdev, IORESOURCE_MEM, port);

		if (res == NULL) {
		pr_err("No memory resource for MAC %d\n",
		priv->port_id);
		err = -ENODEV;
		goto err_gmac;
		}
		priv->base_addr = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(priv->base_addr)) {
		err = PTR_ERR(priv->base_addr);