Commit b658912c authored Apr 19, 2018 by Jiri Kosina

HID: i2c-hid: fix inverted return value from i2c_hid_command()



i2c_hid_command() returns non-zero in error cases (the actual
errno). Error handling in for I2C_HID_QUIRK_RESEND_REPORT_DESCR
case in i2c_hid_resume() had the check inverted; fix that.

Fixes: 3e83eda4 ("HID: i2c-hid: Fix resume issue on Raydium touchscreen device")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 3e83eda4

drivers/hid/i2c-hid/i2c-hid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1229,7 +1229,7 @@ static int i2c_hid_resume(struct device *dev)
		*/
		if (ihid->quirks & I2C_HID_QUIRK_RESEND_REPORT_DESCR) {
		ret = i2c_hid_command(client, &hid_report_descr_cmd, NULL, 0);
		if (!ret)
		if (ret)
		return ret;
		}