Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b655c2c4 authored by Ian Abbott's avatar Ian Abbott Committed by Greg Kroah-Hartman
Browse files

staging: comedi: s626: don't dereference insn->data 



`s626_enc_insn_config()` is incorrectly dereferencing `insn->data` which
is a pointer to user memory.  It should be dereferencing the separate
`data` parameter that points to a copy of the data in kernel memory.

Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
Reviewed-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 67f2021f

drivers/staging/comedi/drivers/s626.c

+1 −1
Original line number Diff line number Diff line
@@ -1825,7 +1825,7 @@ static int s626_enc_insn_config(struct comedi_device *dev, 
	/*   (data==NULL) ? (Preloadvalue=0) : (Preloadvalue=data[0]); */



	k->SetMode(dev, k, Setup, TRUE);

	Preload(dev, k, *(insn->data));

	Preload(dev, k, data[0]);

	k->PulseIndex(dev, k);

	SetLatchSource(dev, k, valueSrclatch);

	k->SetEnable(dev, k, (uint16_t) (enab != 0));