Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6422bc0 authored by Sebastian Sanchez's avatar Sebastian Sanchez Committed by Doug Ledford
Browse files

IB/hfi1: Check xchg returned value for queuing link down entry 



Check xchg returned value for queuing link down entry
to guarantee proper atomic value reads.

Fixes: 626c077c ("IB/hfi1: Prevent link down request double queuing")
Reviewed-by: default avatarMike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: default avatarSebastian Sanchez <sebastian.sanchez@intel.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 028e0a67

drivers/infiniband/hw/hfi1/chip.c

+12 −6
Original line number Diff line number Diff line
@@ -7810,15 +7810,21 @@ static void handle_8051_interrupt(struct hfi1_devdata *dd, u32 unused, u64 reg) 
	if (queue_link_down) {

		/*

		 * if the link is already going down or disabled, do not

		 * queue another

		 * queue another. If there's a link down entry already

		 * queued, don't queue another one.

		 */

		if ((ppd->host_link_state &

		    (HLS_GOING_OFFLINE | HLS_LINK_COOLDOWN)) ||

		    ppd->link_enabled == 0 || ppd->is_link_down_queued) {

			dd_dev_info(dd, "%s: not queuing link down\n",

				    __func__);

		    ppd->link_enabled == 0) {

			dd_dev_info(dd, "%s: not queuing link down. host_link_state %x, link_enabled %x\n",

				    __func__, ppd->host_link_state,

				    ppd->link_enabled);

		} else {

			xchg(&ppd->is_link_down_queued, 1);

			if (xchg(&ppd->is_link_down_queued, 1) == 1)

				dd_dev_info(dd,

					    "%s: link down request already queued\n",

					    __func__);

			else

				queue_work(ppd->link_wq, &ppd->link_down_work);

		}

	}