Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b6104a85 authored by Zhang Qiang's avatar Zhang Qiang Committed by Greg Kroah-Hartman
Browse files

usb: gadget: function: fix missing spinlock in f_uac1_legacy 



commit 8778eb0927ddcd3f431805c37b78fa56481aeed9 upstream.

Add a missing spinlock protection for play_queue, because
the play_queue may be destroyed when the "playback_work"
work func and "f_audio_out_ep_complete" callback func
operate this paly_queue at the same time.

Fixes: c6994e6f ("USB: gadget: add USB Audio Gadget driver")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarZhang Qiang <qiang.zhang@windriver.com>
Signed-off-by: default avatarFelipe Balbi <balbi@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ce367096

drivers/usb/gadget/function/f_uac1_legacy.c

+2 −0
Original line number Diff line number Diff line
@@ -336,7 +336,9 @@ static int f_audio_out_ep_complete(struct usb_ep *ep, struct usb_request *req) 


	/* Copy buffer is full, add it to the play_queue */

	if (audio_buf_size - copy_buf->actual < req->actual) {

		spin_lock_irq(&audio->lock);

		list_add_tail(&copy_buf->list, &audio->play_queue);

		spin_unlock_irq(&audio->lock);

		schedule_work(&audio->playback_work);

		copy_buf = f_audio_buffer_alloc(audio_buf_size);

		if (IS_ERR(copy_buf))