Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b600c5a1 authored by Yong Wu's avatar Yong Wu Committed by Greg Kroah-Hartman
Browse files

driver core: Remove the link if there is no driver with AUTO flag



commit 0fe6f7874d467456da6f6a221dd92499a3ab1780 upstream.

DL_FLAG_AUTOREMOVE_CONSUMER/SUPPLIER means "Remove the link
automatically on consumer/supplier driver unbind", that means we should
remove whole the device_link when there is no this driver no matter what
the ref_count of the link is.

CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarYong Wu <yong.wu@mediatek.com>
Signed-off-by: default avatarSaravana Kannan <saravanak@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6bdf6513
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -546,7 +546,7 @@ static void __device_links_no_driver(struct device *dev)
			continue;

		if (link->flags & DL_FLAG_AUTOREMOVE_CONSUMER)
			kref_put(&link->kref, __device_link_del);
			__device_link_del(&link->kref);
		else if (link->status != DL_STATE_SUPPLIER_UNBIND)
			WRITE_ONCE(link->status, DL_STATE_AVAILABLE);
	}
@@ -591,7 +591,7 @@ void device_links_driver_cleanup(struct device *dev)
		 */
		if (link->status == DL_STATE_SUPPLIER_UNBIND &&
		    link->flags & DL_FLAG_AUTOREMOVE_SUPPLIER)
			kref_put(&link->kref, __device_link_del);
			__device_link_del(&link->kref);

		WRITE_ONCE(link->status, DL_STATE_DORMANT);
	}