Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5d51214 authored by Konrad Rzeszutek Wilk's avatar Konrad Rzeszutek Wilk Committed by David Vrabel
Browse files

xen/pciback: Include the domain id if removing the device whilst still in use 



Cleanup the function a bit - also include the id of the
domain that is using the device.

Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: default avatarDavid Vrabel <david.vrabel@citrix.com>
Signed-off-by: default avatarDavid Vrabel <david.vrabel@citrix.com>
parent ac801022

drivers/xen/xen-pciback/pci_stub.c

+6 −4
Original line number Original line Diff line number Diff line
@@ -553,12 +553,14 @@ static void pcistub_remove(struct pci_dev *dev) 
	spin_unlock_irqrestore(&pcistub_devices_lock, flags);

	spin_unlock_irqrestore(&pcistub_devices_lock, flags);





	if (found_psdev) {

	if (found_psdev) {

		dev_dbg(&dev->dev, "found device to remove - in use? %p\n",

		dev_dbg(&dev->dev, "found device to remove %s\n",

			found_psdev->pdev);

			found_psdev->pdev ? "- in-use" : "");





		if (found_psdev->pdev) {

		if (found_psdev->pdev) {

			pr_warn("****** removing device %s while still in-use! ******\n",

			int domid = xen_find_device_domain_owner(dev);

			       pci_name(found_psdev->dev));



			pr_warn("****** removing device %s while still in-use by domain %d! ******\n",

			       pci_name(found_psdev->dev), domid);

			pr_warn("****** driver domain may still access this device's i/o resources!\n");

			pr_warn("****** driver domain may still access this device's i/o resources!\n");

			pr_warn("****** shutdown driver domain before binding device\n");

			pr_warn("****** shutdown driver domain before binding device\n");

			pr_warn("****** to other drivers or domains\n");

			pr_warn("****** to other drivers or domains\n");