Commit b5c2a944 authored Jul 06, 2020 by Andre Edich Committed by Greg Kroah-Hartman Jul 16, 2020

smsc95xx: avoid memory leak in smsc95xx_bind



[ Upstream commit 3ed58f96a70b85ef646d5427258f677f1395b62f ]

In a case where the ID_REV register read is failed, the memory for a
private data structure has to be freed before returning error from the
function smsc95xx_bind.

Fixes: bbd9f9ee ("smsc95xx: add wol support for more frame types")
Signed-off-by: Andre Edich <andre.edich@microchip.com>
Signed-off-by: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 10929819

drivers/net/usb/smsc95xx.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1307,7 +1307,8 @@ static int smsc95xx_bind(struct usbnet dev, struct usb_interface intf)
		/* detect device revision as different features may be available */
		ret = smsc95xx_read_reg(dev, ID_REV, &val);
		if (ret < 0)
		return ret;
		goto free_pdata;

		val >>= 16;
		pdata->chip_id = val;
		pdata->mdix_ctrl = get_mdix_status(dev->net);