Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b578b87b authored by Julian Wiedmann's avatar Julian Wiedmann Committed by Greg Kroah-Hartman
Browse files

s390/qdio: don't touch the dsci in tiqdio_add_input_queues() 



commit ac6639cd3db607d386616487902b4cc1850a7be5 upstream.

Current code sets the dsci to 0x00000080. Which doesn't make any sense,
as the indicator area is located in the _left-most_ byte.

Worse: if the dsci is the _shared_ indicator, this potentially clears
the indication of activity for a _different_ device.
tiqdio_thinint_handler() will then have no reason to call that device's
IRQ handler, and the device ends up stalling.

Fixes: d0c9d4a8 ("[S390] qdio: set correct bit in dsci")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJulian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b1d52630

drivers/s390/cio/qdio_thinint.c

+0 −1
Original line number Diff line number Diff line
@@ -79,7 +79,6 @@ void tiqdio_add_input_queues(struct qdio_irq *irq_ptr) 
	mutex_lock(&tiq_list_lock);

	list_add_rcu(&irq_ptr->input_qs[0]->entry, &tiq_list);

	mutex_unlock(&tiq_list_lock);

	xchg(irq_ptr->dsci, 1 << 7);

}



void tiqdio_remove_input_queues(struct qdio_irq *irq_ptr)