Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5357081 authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

libata: don't use on-stack sense buffer 



sense_buffer is used as DMA target and shouldn't be allocated on
stack.  Use ap->sector_buf instead.  This problem is spotted by Chuck
Ebbert.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Reported-by: default avatarChuck Ebbert <cebbert@redhat.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 84bda12a

drivers/ata/libata-eh.c

+1 −1
Original line number Diff line number Diff line
@@ -2901,7 +2901,7 @@ static int atapi_eh_clear_ua(struct ata_device *dev) 
	int i;



	for (i = 0; i < ATA_EH_UA_TRIES; i++) {

		u8 sense_buffer[SCSI_SENSE_BUFFERSIZE];

		u8 *sense_buffer = dev->link->ap->sector_buf;

		u8 sense_key = 0;

		unsigned int err_mask;