Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4f2ab43 authored by Daniel Lezcano's avatar Daniel Lezcano Committed by Ingo Molnar
Browse files

sched: Remove 'cpu' parameter from idle_balance() 



The cpu parameter passed to idle_balance() is not needed as it could
be retrieved from 'struct rq.'

Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Cc: alex.shi@linaro.org
Signed-off-by: default avatarPeter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1389949444-14821-1-git-send-email-daniel.lezcano@linaro.org


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent d0ea0268

kernel/sched/core.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -2705,7 +2705,7 @@ static void __sched __schedule(void) 
	pre_schedule(rq, prev);

	pre_schedule(rq, prev);





	if (unlikely(!rq->nr_running))

	if (unlikely(!rq->nr_running))

		idle_balance(cpu, rq);

		idle_balance(rq);





	put_prev_task(rq, prev);

	put_prev_task(rq, prev);

	next = pick_next_task(rq);

	next = pick_next_task(rq);

kernel/sched/fair.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -6531,12 +6531,13 @@ static int load_balance(int this_cpu, struct rq *this_rq, 
 * idle_balance is called by schedule() if this_cpu is about to become

 * idle_balance is called by schedule() if this_cpu is about to become

 * idle. Attempts to pull tasks from other CPUs.

 * idle. Attempts to pull tasks from other CPUs.

 */

 */

void idle_balance(int this_cpu, struct rq *this_rq)

void idle_balance(struct rq *this_rq)

{

{

	struct sched_domain *sd;

	struct sched_domain *sd;

	int pulled_task = 0;

	int pulled_task = 0;

	unsigned long next_balance = jiffies + HZ;

	unsigned long next_balance = jiffies + HZ;

	u64 curr_cost = 0;

	u64 curr_cost = 0;

	int this_cpu = this_rq->cpu;





	this_rq->idle_stamp = rq_clock(this_rq);

	this_rq->idle_stamp = rq_clock(this_rq);

kernel/sched/sched.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -1158,7 +1158,7 @@ extern const struct sched_class idle_sched_class; 
extern void update_group_power(struct sched_domain *sd, int cpu);

extern void update_group_power(struct sched_domain *sd, int cpu);





extern void trigger_load_balance(struct rq *rq);

extern void trigger_load_balance(struct rq *rq);

extern void idle_balance(int this_cpu, struct rq *this_rq);

extern void idle_balance(struct rq *this_rq);





extern void idle_enter_fair(struct rq *this_rq);

extern void idle_enter_fair(struct rq *this_rq);

extern void idle_exit_fair(struct rq *this_rq);

extern void idle_exit_fair(struct rq *this_rq);