Commit b4eab56d authored Feb 10, 2020 by Larry Finger Committed by Greg Kroah-Hartman Feb 28, 2020

staging: rtl8188eu: Fix potential overuse of kernel memory



commit 4ddf8ab8d15ddbc52eefb44eb64e38466ce1f70f upstream.

In routine wpa_supplicant_ioctl(), the user-controlled p->length is
checked to be at least the size of struct ieee_param size, but the code
does not detect the case where p->length is greater than the size
of the struct, thus a malicious user could be wasting kernel memory.
Fixes commit a2c60d42 ("Add files for new driver - part 16").

Reported by: Pietro Oliva <pietroliva@gmail.com>
Cc: Pietro Oliva <pietroliva@gmail.com>
Cc: Stable <stable@vger.kernel.org>
Fixes commit a2c60d42 ("Add files for new driver - part 16").
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Link: https://lore.kernel.org/r/20200210180235.21691-4-Larry.Finger@lwfinger.net


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2a50bd9e

drivers/staging/rtl8188eu/os_dep/ioctl_linux.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2026,7 +2026,7 @@ static int wpa_supplicant_ioctl(struct net_device dev, struct iw_point p)
		struct ieee_param *param;
		uint ret = 0;

		if (p->length < sizeof(struct ieee_param) \|\| !p->pointer) {
		if (!p->pointer \|\| p->length != sizeof(struct ieee_param)) {
		ret = -EINVAL;
		goto out;
		}