Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4869ee9 authored by Varun Prakash's avatar Varun Prakash Committed by Nicholas Bellinger
Browse files

iscsi-target: call complete on conn_logout_comp 



ISCSI_HW_OFFLOAD transport drivers waits
on conn_logout_comp as ISCSI_TCP driver
so call complete if transport type
is ISCSI_HW_OFFLOAD.

Signed-off-by: default avatarVarun Prakash <varun@chelsio.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 1c50ff42

drivers/target/iscsi/iscsi_target.c

+6 −4
Original line number Diff line number Diff line
@@ -4063,16 +4063,18 @@ int iscsit_close_connection( 
	pr_debug("Closing iSCSI connection CID %hu on SID:"

		" %u\n", conn->cid, sess->sid);

	/*

	 * Always up conn_logout_comp for the traditional TCP case just in case

	 * the RX Thread in iscsi_target_rx_opcode() is sleeping and the logout

	 * response never got sent because the connection failed.

	 * Always up conn_logout_comp for the traditional TCP and HW_OFFLOAD

	 * case just in case the RX Thread in iscsi_target_rx_opcode() is

	 * sleeping and the logout response never got sent because the

	 * connection failed.

	 *

	 * However for iser-target, isert_wait4logout() is using conn_logout_comp

	 * to signal logout response TX interrupt completion.  Go ahead and skip

	 * this for iser since isert_rx_opcode() does not wait on logout failure,

	 * and to avoid iscsi_conn pointer dereference in iser-target code.

	 */

	if (conn->conn_transport->transport_type == ISCSI_TCP)

	if ((conn->conn_transport->transport_type == ISCSI_TCP) ||

	    (conn->conn_transport->transport_type == ISCSI_HW_OFFLOAD))

		complete(&conn->conn_logout_comp);



	if (!strcmp(current->comm, ISCSI_RX_THREAD_NAME)) {