Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b46d37e6 authored by Jiri Slaby's avatar Jiri Slaby Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (13963): siano, fix memory leak 



Stanse found a memory leak in smscore_gpio_configure. buffer is not
freed/assigned on all paths. Fix that.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ad695510

drivers/media/dvb/siano/smscoreapi.c

+5 −2
Original line number Diff line number Diff line
@@ -1459,8 +1459,10 @@ int smscore_gpio_configure(struct smscore_device_t *coredev, u8 PinNum, 
	if (!(coredev->device_flags & SMS_DEVICE_FAMILY2)) {

		pMsg->xMsgHeader.msgType = MSG_SMS_GPIO_CONFIG_REQ;

		if (GetGpioPinParams(PinNum, &TranslatedPinNum, &GroupNum,

				&groupCfg) != 0)

			return -EINVAL;

				&groupCfg) != 0) {

			rc = -EINVAL;

			goto free;

		}



		pMsg->msgData[1] = TranslatedPinNum;

		pMsg->msgData[2] = GroupNum;
@@ -1490,6 +1492,7 @@ int smscore_gpio_configure(struct smscore_device_t *coredev, u8 PinNum, 
		else

			sms_err("smscore_gpio_configure error");

	}

free:

	kfree(buffer);



	return rc;