Commit b469f21b authored Apr 10, 2021 by Sergey Shtylyov Committed by Greg Kroah-Hartman May 22, 2021

i2c: sh7760: add IRQ check



[ Upstream commit e5b2e3e742015dd2aa6bc7bcef2cb59b2de1221c ]

The driver neglects to check the result of platform_get_irq()'s call and
blithely passes the negative error codes to devm_request_irq() (which
takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding
an original error code.  Stop calling devm_request_irq() with invalid
IRQ #s.

Fixes: a26c20b1 ("i2c: Renesas SH7760 I2C master driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 06f09e43

drivers/i2c/busses/i2c-sh7760.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -471,7 +471,10 @@ static int sh7760_i2c_probe(struct platform_device *pdev)
		goto out2;
		}

		id->irq = platform_get_irq(pdev, 0);
		ret = platform_get_irq(pdev, 0);
		if (ret < 0)
		return ret;
		id->irq = ret;

		id->adap.nr = pdev->id;
		id->adap.algo = &sh7760_i2c_algo;