Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4212737 authored by David Howells's avatar David Howells Committed by James Morris
Browse files

CRED: Wrap task credential accesses in the MIPS arch 



Wrap access to task credentials so that they can be separated more easily from
the task_struct during the introduction of COW creds.

Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

Change some task->e?[ug]id to task_e?[ug]id().  In some places it makes more
sense to use RCU directly rather than a convenient wrapper; these will be
addressed by later patches.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarJames Morris <jmorris@namei.org>
Acked-by: default avatarSerge Hallyn <serue@us.ibm.com>
Acked-by: default avatarRalf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent ef81ee98

arch/mips/kernel/mips-mt-fpaff.c

+3 −2
Original line number Original line Diff line number Diff line
@@ -51,6 +51,7 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len, 
	int retval;

	int retval;

	struct task_struct *p;

	struct task_struct *p;

	struct thread_info *ti;

	struct thread_info *ti;

	uid_t euid;





	if (len < sizeof(new_mask))

	if (len < sizeof(new_mask))

		return -EINVAL;

		return -EINVAL;
@@ -76,9 +77,9 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len, 
	 */

	 */

	get_task_struct(p);

	get_task_struct(p);





	euid = current_euid();

	retval = -EPERM;

	retval = -EPERM;

	if ((current->euid != p->euid) && (current->euid != p->uid) &&

	if (euid != p->euid && euid != p->uid && !capable(CAP_SYS_NICE)) {

			!capable(CAP_SYS_NICE)) {

		read_unlock(&tasklist_lock);

		read_unlock(&tasklist_lock);

		goto out_unlock;

		goto out_unlock;

	}

	}