Commit b3404a8e authored Apr 08, 2013 by Frank Schaefer Committed by Mauro Carvalho Chehab Apr 25, 2013

[media] em28xx: save isoc endpoint number for DVB only if endpoint has alt...


[media] em28xx: save isoc endpoint number for DVB only if endpoint has alt settings with xMaxPacketSize != 0

X-Patchwork-Delegate: mchehab@redhat.com
In addition to commit 72cc9ba3 "em28xx: ignore isoc DVB USB endpoints with
wMaxPacketSize = 0 bytes for all alt settings" we should not save the endpoint
number of the isoc DVB endpoint before it has been validated.
While the current code works fine, dev->dvb_ep_isoc != 0 could be interpreted
as indicator that the device provides DVB support.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent cb132cd5

drivers/media/usb/em28xx/em28xx-cards.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3220,9 +3220,9 @@ static int em28xx_usb_probe(struct usb_interface *interface,
		e->bEndpointAddress;
		} else {
		if (usb_endpoint_xfer_isoc(e)) {
		dev->dvb_ep_isoc = e->bEndpointAddress;
		if (size > dev->dvb_max_pkt_size_isoc) {
		has_dvb = true; /* see NOTE (~) */
		dev->dvb_ep_isoc = e->bEndpointAddress;
		dev->dvb_max_pkt_size_isoc = size;
		dev->dvb_alt_isoc = i;
		}