Commit b33d3b73 authored May 16, 2016 by Greg Rose Committed by Jeff Kirsher Jun 27, 2016

i40e: Clean up MSIX IRQs before suspend

The i40e_suspend() function calls another function that preps the device
for the power save and resume by freeing all the Tx/Rx resources and
interrupts but that function does not free the "other" causes interrupt
vector and IRQ. It also fails to call synchronize_irq() before freeing
the IRQ vectors. This sometimes may result in some AER errors on those
systems with that PCIe error reporting feature enabled.

Call synchronize_irq() before freeing IRQ vectors and explicitly free
the other causes interrupt resources and shut down that MSIX interrupt.

Change-ID: Ib88e4536756518a352446da0232189716618ad81
Signed-off-by: Greg Rose <gregory.v.rose@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 0e8d95f8

drivers/net/ethernet/intel/i40e/i40e_main.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -3950,6 +3950,7 @@ static void i40e_vsi_free_irq(struct i40e_vsi *vsi)
		/* clear the affinity_mask in the IRQ descriptor */
		irq_set_affinity_hint(pf->msix_entries[vector].vector,
		NULL);
		synchronize_irq(pf->msix_entries[vector].vector);
		free_irq(pf->msix_entries[vector].vector,
		vsi->q_vectors[i]);

		@@ -11451,6 +11452,8 @@ static int i40e_suspend(struct pci_dev *pdev, pm_message_t state)
		wr32(hw, I40E_PFPM_APM, (pf->wol_en ? I40E_PFPM_APM_APME_MASK : 0));
		wr32(hw, I40E_PFPM_WUFC, (pf->wol_en ? I40E_PFPM_WUFC_MAG_MASK : 0));

		i40e_stop_misc_vector(pf);

		pci_wake_from_d3(pdev, pf->wol_en);
		pci_set_power_state(pdev, PCI_D3hot);