Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b30dd5c0 authored by Ivo van Doorn's avatar Ivo van Doorn Committed by John W. Linville
Browse files

rt2x00: Introduce RXDONE_SIGNAL_MASK mask 



Improve error message reporting when a frame was received
with unknown rate. Instead of using the boolean check if
the frame is supposed to be a PLCP value or not, we should
add a new mask (RXDONE_SIGNAL_MASK) which returns the type
identification for a signal value (i.e. PLCP). At the moment
we only have 2 different types, but more will arrive when
support for 11n is added.

Signed-off-by: default avatarIvo van Doorn <IvDoorn@gmail.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 2bdb35c7

drivers/net/wireless/rt2x00/rt2x00dev.c

+2 −2
Original line number Diff line number Diff line
@@ -392,8 +392,8 @@ void rt2x00lib_rxdone(struct rt2x00_dev *rt2x00dev, 


	if (idx < 0) {

		WARNING(rt2x00dev, "Frame received with unrecognized signal,"

			"signal=0x%.2x, plcp=%d.\n", rxdesc.signal,

			!!(rxdesc.dev_flags & RXDONE_SIGNAL_PLCP));

			"signal=0x%.2x, type=%d.\n", rxdesc.signal,

			(rxdesc.dev_flags & RXDONE_SIGNAL_MASK));

		idx = 0;

	}

drivers/net/wireless/rt2x00/rt2x00queue.h

+8 −0
Original line number Diff line number Diff line
@@ -157,6 +157,14 @@ enum rxdone_entry_desc_flags { 
	RXDONE_CRYPTO_ICV = 1 << 4,

};



/**

 * RXDONE_SIGNAL_MASK - Define to mask off all &rxdone_entry_desc_flags flags

 * except for the RXDONE_SIGNAL_* flags. This is useful to convert the dev_flags

 * from &rxdone_entry_desc to a signal value type.

 */

#define RXDONE_SIGNAL_MASK \

       ( RXDONE_SIGNAL_PLCP | RXDONE_SIGNAL_BITRATE )



/**

 * struct rxdone_entry_desc: RX Entry descriptor

 *