Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2d63989 authored by Markus Pargmann's avatar Markus Pargmann Committed by Vinod Koul
Browse files

dma: mxs-dma: Cleanup interrupt handler 



The DMA interrupt handler uses its controll registers to handle all
available channel interrupts it can find.

This patch changes it to handle only one interrupt by directly mapping
irq number to channel. It also includes a cleanup of the ctrl-register
usage.

Signed-off-by: default avatarMarkus Pargmann <mpa@pengutronix.de>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 8de7a7d9

drivers/dma/mxs-dma.c

+60 −36
Original line number Diff line number Diff line
@@ -27,6 +27,7 @@ 
#include <linux/of.h>

#include <linux/of_device.h>

#include <linux/of_dma.h>

#include <linux/list.h>



#include <asm/irq.h>
@@ -272,40 +273,66 @@ static void mxs_dma_tasklet(unsigned long data) 
		mxs_chan->desc.callback(mxs_chan->desc.callback_param);

}



static int mxs_dma_irq_to_chan(struct mxs_dma_engine *mxs_dma, int irq)

{

	int i;



	for (i = 0; i != mxs_dma->nr_channels; ++i)

		if (mxs_dma->mxs_chans[i].chan_irq == irq)

			return i;



	return -EINVAL;

}



static irqreturn_t mxs_dma_int_handler(int irq, void *dev_id)

{

	struct mxs_dma_engine *mxs_dma = dev_id;

	u32 stat1, stat2;

	struct mxs_dma_chan *mxs_chan;

	u32 completed;

	u32 err;

	int chan = mxs_dma_irq_to_chan(mxs_dma, irq);



	if (chan < 0)

		return IRQ_NONE;



	/* completion status */

	stat1 = readl(mxs_dma->base + HW_APBHX_CTRL1);

	stat1 &= MXS_DMA_CHANNELS_MASK;

	writel(stat1, mxs_dma->base + HW_APBHX_CTRL1 + STMP_OFFSET_REG_CLR);

	completed = readl(mxs_dma->base + HW_APBHX_CTRL1);

	completed = (completed >> chan) & 0x1;



	/* Clear interrupt */

	writel((1 << chan),

			mxs_dma->base + HW_APBHX_CTRL1 + STMP_OFFSET_REG_CLR);



	/* error status */

	stat2 = readl(mxs_dma->base + HW_APBHX_CTRL2);

	writel(stat2, mxs_dma->base + HW_APBHX_CTRL2 + STMP_OFFSET_REG_CLR);

	err = readl(mxs_dma->base + HW_APBHX_CTRL2);

	err &= (1 << (MXS_DMA_CHANNELS + chan)) | (1 << chan);



	/*

	 * error status bit is in the upper 16 bits, error irq bit in the lower

	 * 16 bits. We transform it into a simpler error code:

	 * err: 0x00 = no error, 0x01 = TERMINATION, 0x02 = BUS_ERROR

	 */

	err = (err >> (MXS_DMA_CHANNELS + chan)) + (err >> chan);



	/* Clear error irq */

	writel((1 << chan),

			mxs_dma->base + HW_APBHX_CTRL2 + STMP_OFFSET_REG_CLR);



	/*

	 * When both completion and error of termination bits set at the

	 * same time, we do not take it as an error.  IOW, it only becomes

	 * an error we need to handle here in case of either it's (1) a bus

	 * error or (2) a termination error with no completion.

	 * an error we need to handle here in case of either it's a bus

	 * error or a termination error with no completion. 0x01 is termination

	 * error, so we can subtract err & completed to get the real error case.

	 */

	stat2 = ((stat2 >> MXS_DMA_CHANNELS) & stat2) | /* (1) */

		(~(stat2 >> MXS_DMA_CHANNELS) & stat2 & ~stat1); /* (2) */

	err -= err & completed;



	/* combine error and completion status for checking */

	stat1 = (stat2 << MXS_DMA_CHANNELS) | stat1;

	while (stat1) {

		int channel = fls(stat1) - 1;

		struct mxs_dma_chan *mxs_chan =

			&mxs_dma->mxs_chans[channel % MXS_DMA_CHANNELS];

	mxs_chan = &mxs_dma->mxs_chans[chan];



		if (channel >= MXS_DMA_CHANNELS) {

	if (err) {

		dev_dbg(mxs_dma->dma_device.dev,

			"%s: error in channel %d\n", __func__,

				channel - MXS_DMA_CHANNELS);

			chan);

		mxs_chan->status = DMA_ERROR;

		mxs_dma_reset_chan(mxs_chan);

	} else {
@@ -315,14 +342,11 @@ static irqreturn_t mxs_dma_int_handler(int irq, void *dev_id) 
			mxs_chan->status = DMA_COMPLETE;

	}



		stat1 &= ~(1 << channel);



	if (mxs_chan->status == DMA_COMPLETE)

		dma_cookie_complete(&mxs_chan->desc);



	/* schedule tasklet on this channel */

	tasklet_schedule(&mxs_chan->tasklet);

	}



	return IRQ_HANDLED;

}