Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b280dab6 authored by Jean Delvare's avatar Jean Delvare Committed by Greg Kroah-Hartman
Browse files

[PATCH] I2C: Drop probe parameter of i2c-keywest 



The i2c-keywest driver has a "probe" module parameter which enables bus
scanning at load time. This can be done in userspace with the i2cdetect
tool (part of the lm_sensors package) instead. What's more, i2cdetect
gives more control on the way the bus is scanned, and is safer
(i2c-keywest currently scans reserved addresses and doesn't properly
handle the famous 24RF08 corruption case.)

Thus, I would propose that this module parameter be simply dropped.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Acked-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 386625f9

drivers/i2c/busses/i2c-keywest.c

+0 −12
Original line number Diff line number Diff line
@@ -87,12 +87,9 @@ static const char *__kw_state_names[] = { 
};

#endif /* DEBUG */



static int probe;



MODULE_AUTHOR("Benjamin Herrenschmidt <benh@kernel.crashing.org>");

MODULE_DESCRIPTION("I2C driver for Apple's Keywest");

MODULE_LICENSE("GPL");

module_param(probe, bool, 0);



#ifdef POLLED_MODE

/* Don't schedule, the g5 fan controller is too
@@ -632,15 +629,6 @@ create_iface(struct device_node *np, struct device *dev) 
				chan->adapter.name);

			i2c_set_adapdata(&chan->adapter, NULL);

		}

		if (probe) {

			printk("Probe: ");

			for (addr = 0x00; addr <= 0x7f; addr++) {

				if (i2c_smbus_xfer(&chan->adapter,addr,

				    0,0,0,I2C_SMBUS_QUICK,NULL) >= 0)

					printk("%02x ", addr);

			}

			printk("\n");

		}

	}



	printk(KERN_INFO "Found KeyWest i2c on \"%s\", %d channel%s, stepping: %d bits\n",