Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b27e3648 authored by Martin Blumenstingl's avatar Martin Blumenstingl Committed by Linus Walleij
Browse files

pinctrl: meson: fix uart_ao_b for GXBB and GXL/GXM 



The GXBB and GXL/GXM pinctrl drivers had a configuration which conflicts
with uart_ao_a. According to the GXBB ("S905") datasheet the AO UART
functions are:
- GPIOAO_0: Func1 = UART_TX_AO_A (bit 12), Func2 = UART_TX_AO_B (bit 26)
- GPIOAO_1: Func1 = UART_RX_AO_A (bit 11), Func2 = UART_RX_AO_B (bit 25)
- GPIOAO_4: Func2 = UART_TX_AO_B (bit 24)
- GPIOAO_5: Func2 = UART_RX_AO_B (bit 25)

The existing definition for uart_AO_A already uses GPIOAO_0 and GPIOAO_1.
The old definition of uart_AO_B however was broken, as it used GPIOAO_0
for TX (which would be fine) and two pins (GPIOAO_1 and GPIOAO_5) for RX
(which does not make any sense).

This fixes the uart_AO_B configuration by moving it to GPIOAO_4 and
GPIOAO_5 (it would be possible to use GPIOAO_0 and GPIOAO_1 in theory,
but all existing hardware uses uart_AO_A there).
The fix for GXBB and GXL/GXM is identical since it seems that these
specific pins are identical on both SoC variants.

Signed-off-by: default avatarMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: default avatarKevin Hilman <khilman@baylibre.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 581d3c20

drivers/pinctrl/meson/pinctrl-meson-gxbb.c

+3 −4
Original line number Diff line number Diff line
@@ -253,9 +253,8 @@ static const unsigned int uart_tx_ao_a_pins[] = { PIN(GPIOAO_0, 0) }; 
static const unsigned int uart_rx_ao_a_pins[]	= { PIN(GPIOAO_1, 0) };

static const unsigned int uart_cts_ao_a_pins[]	= { PIN(GPIOAO_2, 0) };

static const unsigned int uart_rts_ao_a_pins[]	= { PIN(GPIOAO_3, 0) };

static const unsigned int uart_tx_ao_b_pins[]	= { PIN(GPIOAO_0, 0) };

static const unsigned int uart_rx_ao_b_pins[]	= { PIN(GPIOAO_1, 0),

						    PIN(GPIOAO_5, 0) };

static const unsigned int uart_tx_ao_b_pins[]	= { PIN(GPIOAO_4, 0) };

static const unsigned int uart_rx_ao_b_pins[]	= { PIN(GPIOAO_5, 0) };

static const unsigned int uart_cts_ao_b_pins[]	= { PIN(GPIOAO_2, 0) };

static const unsigned int uart_rts_ao_b_pins[]	= { PIN(GPIOAO_3, 0) };
@@ -498,7 +497,7 @@ static struct meson_pmx_group meson_gxbb_aobus_groups[] = { 
	GPIO_GROUP(GPIOAO_13, 0),



	/* bank AO */

	GROUP(uart_tx_ao_b,	0,	26),

	GROUP(uart_tx_ao_b,	0,	24),

	GROUP(uart_rx_ao_b,	0,	25),

	GROUP(uart_tx_ao_a,	0,	12),

	GROUP(uart_rx_ao_a,	0,	11),

drivers/pinctrl/meson/pinctrl-meson-gxl.c

+3 −4
Original line number Diff line number Diff line
@@ -214,9 +214,8 @@ static const unsigned int uart_tx_ao_a_pins[] = { PIN(GPIOAO_0, 0) }; 
static const unsigned int uart_rx_ao_a_pins[]	= { PIN(GPIOAO_1, 0) };

static const unsigned int uart_cts_ao_a_pins[]	= { PIN(GPIOAO_2, 0) };

static const unsigned int uart_rts_ao_a_pins[]	= { PIN(GPIOAO_3, 0) };

static const unsigned int uart_tx_ao_b_pins[]	= { PIN(GPIOAO_0, 0) };

static const unsigned int uart_rx_ao_b_pins[]	= { PIN(GPIOAO_1, 0),

						    PIN(GPIOAO_5, 0) };

static const unsigned int uart_tx_ao_b_pins[]	= { PIN(GPIOAO_4, 0) };

static const unsigned int uart_rx_ao_b_pins[]	= { PIN(GPIOAO_5, 0) };

static const unsigned int uart_cts_ao_b_pins[]	= { PIN(GPIOAO_2, 0) };

static const unsigned int uart_rts_ao_b_pins[]	= { PIN(GPIOAO_3, 0) };
@@ -409,7 +408,7 @@ static struct meson_pmx_group meson_gxl_aobus_groups[] = { 
	GPIO_GROUP(GPIOAO_9, 0),



	/* bank AO */

	GROUP(uart_tx_ao_b,	0,	26),

	GROUP(uart_tx_ao_b,	0,	24),

	GROUP(uart_rx_ao_b,	0,	25),

	GROUP(uart_tx_ao_a,	0,	12),

	GROUP(uart_rx_ao_a,	0,	11),