Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b27dd264 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

usb: host: ohci-pxa27x: Fix and & vs | typo 



commit 0709831a50d31b3caf2237e8d7fe89e15b0d919d upstream.

The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's
a no-op because of the & vs | typo.  This bug predates git and it was
only discovered using static analysis so it must not affect too many
people in real life.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20190817065520.GA29951@mwanda


Signed-off-by: default avatarNobuhiro Iwamatsu (CIP) <nobuhiro1.iwamatsu@toshiba.co.jp>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 76d41dc2

drivers/usb/host/ohci-pxa27x.c

+1 −1
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) 
		uhcrhda |= RH_A_NPS;

		break;

	case PMM_GLOBAL_MODE:

		uhcrhda &= ~(RH_A_NPS & RH_A_PSM);

		uhcrhda &= ~(RH_A_NPS | RH_A_PSM);

		break;

	case PMM_PERPORT_MODE:

		uhcrhda &= ~(RH_A_NPS);