Commit b1e952b4 authored Nov 24, 2014 by Christoffer Dall Committed by Marc Zyngier Nov 25, 2014

arm/arm64: vgic: Remove unreachable irq_clear_pending



When 'injecting' an edge-triggered interrupt with a falling edge we
shouldn't clear the pending state on the distributor.  In fact, we
don't, because the check in vgic_validate_injection would prevent us
from ever reaching this bit of code.

Remove the unreachable snippet.

Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

parent 5100f983

virt/kvm/arm/vgic.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1643,8 +1643,6 @@ static bool vgic_update_irq_pending(struct kvm *kvm, int cpuid,
		vgic_dist_irq_clear_level(vcpu, irq_num);
		if (!vgic_dist_irq_soft_pend(vcpu, irq_num))
		vgic_dist_irq_clear_pending(vcpu, irq_num);
		} else {
		vgic_dist_irq_clear_pending(vcpu, irq_num);
		}

		ret = false;