Commit b1835d23 authored Nov 06, 2014 by Andy Shevchenko Committed by Greg Kroah-Hartman Nov 06, 2014

serial: 8250_dma: no need to set tx_err twice

In the serial8250_tx_dma() the tx_err flag is set in case of error. Thus, there
is no need to repeat this in __dma_tx_complete().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2dc98946

drivers/tty/serial/8250/8250_dma.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -39,7 +39,6 @@ static void __dma_tx_complete(void *param)

		ret = serial8250_tx_dma(p);
		if (ret) {
		dma->tx_err = 1;
		p->ier \|= UART_IER_THRI;
		serial_port_out(&p->port, UART_IER, p->ier);
		}
		@@ -93,7 +92,6 @@ int serial8250_tx_dma(struct uart_8250_port *p)
		}

		dma->tx_running = 1;

		desc->callback = __dma_tx_complete;
		desc->callback_param = p;