Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1357cfb authored by Zahari Doychev's avatar Zahari Doychev Committed by David S. Miller
Browse files

rocker: fix kcalloc parameter order 



The function calls to kcalloc use wrong parameter order and incorrect flags
values. GFP_KERNEL is used instead of flags now and the order is corrected.

The change was done using the following coccinelle script:

@@
expression E1,E2;
type T;
@@

-kcalloc(E1, E2, sizeof(T))
+kcalloc(E2, sizeof(T), GFP_KERNEL)

Signed-off-by: default avatarZahari Doychev <zahari.doychev@linux.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f530f39f

drivers/net/ethernet/rocker/rocker_ofdpa.c

+2 −2
Original line number Diff line number Diff line
@@ -1177,7 +1177,7 @@ static int ofdpa_group_l2_fan_out(struct ofdpa_port *ofdpa_port, 
	entry->group_id = group_id;

	entry->group_count = group_count;



	entry->group_ids = kcalloc(flags, group_count, sizeof(u32));

	entry->group_ids = kcalloc(group_count, sizeof(u32), GFP_KERNEL);

	if (!entry->group_ids) {

		kfree(entry);

		return -ENOMEM;
@@ -1456,7 +1456,7 @@ static int ofdpa_port_vlan_flood_group(struct ofdpa_port *ofdpa_port, 
	int err = 0;

	int i;



	group_ids = kcalloc(flags, port_count, sizeof(u32));

	group_ids = kcalloc(port_count, sizeof(u32), GFP_KERNEL);

	if (!group_ids)

		return -ENOMEM;