Commit b0f73bc7 authored Dec 08, 2017 by Randy Dunlap Committed by Jason Wessel Jan 25, 2018

kdb: drop newline in unknown command output



When an unknown command is entered, kdb prints "Unknown kdb command:"
and then the unknown text, including the newline character. This
causes the ending single-quote mark to be printed on the next line
by itself, so just change the ending newline character to a null
character (end of string) so that it won't be "printed."

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: kgdb-bugreport@lists.sourceforge.net
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

parent 1e0ce03b

kernel/debug/kdb/kdb_main.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -1150,6 +1150,16 @@ void kdb_set_current_task(struct task_struct *p)
		kdb_current_regs = NULL;
		}

		static void drop_newline(char *buf)
		{
		size_t len = strlen(buf);

		if (len == 0)
		return;
		if (*(buf + len - 1) == '\n')
		*(buf + len - 1) = '\0';
		}

		/*
		* kdb_local - The main code for kdb. This routine is invoked on a
		* specific processor, it is not global. The main kdb() routine
		@@ -1327,6 +1337,7 @@ static int kdb_local(kdb_reason_t reason, int error, struct pt_regs *regs,
		cmdptr = cmd_head;
		diag = kdb_parse(cmdbuf);
		if (diag == KDB_NOTFOUND) {
		drop_newline(cmdbuf);
		kdb_printf("Unknown kdb command: '%s'\n", cmdbuf);
		diag = 0;
		}