Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit b082b2e1 authored by Shawn Nematbakhsh's avatar Shawn Nematbakhsh Committed by Benson Leung
Browse files

platform/chrome: cros_ec_debugfs: Add PD port info to debugfs 



Add info useful for debugging USB-PD port state.

Signed-off-by: default avatarShawn Nematbakhsh <shawnn@chromium.org>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarBenson Leung <bleung@chromium.org>
parent f6319280

drivers/platform/chrome/cros_ec_debugfs.c

+72 −0
Original line number Diff line number Diff line
@@ -211,6 +211,58 @@ static int cros_ec_console_log_release(struct inode *inode, struct file *file) 
	return 0;

}



static ssize_t cros_ec_pdinfo_read(struct file *file,

				   char __user *user_buf,

				   size_t count,

				   loff_t *ppos)

{

	char read_buf[EC_USB_PD_MAX_PORTS * 40], *p = read_buf;

	struct cros_ec_debugfs *debug_info = file->private_data;

	struct cros_ec_device *ec_dev = debug_info->ec->ec_dev;

	struct {

		struct cros_ec_command msg;

		union {

			struct ec_response_usb_pd_control_v1 resp;

			struct ec_params_usb_pd_control params;

		};

	} __packed ec_buf;

	struct cros_ec_command *msg;

	struct ec_response_usb_pd_control_v1 *resp;

	struct ec_params_usb_pd_control *params;

	int i;



	msg = &ec_buf.msg;

	params = (struct ec_params_usb_pd_control *)msg->data;

	resp = (struct ec_response_usb_pd_control_v1 *)msg->data;



	msg->command = EC_CMD_USB_PD_CONTROL;

	msg->version = 1;

	msg->insize = sizeof(*resp);

	msg->outsize = sizeof(*params);



	/*

	 * Read status from all PD ports until failure, typically caused

	 * by attempting to read status on a port that doesn't exist.

	 */

	for (i = 0; i < EC_USB_PD_MAX_PORTS; ++i) {

		params->port = i;

		params->role = 0;

		params->mux = 0;

		params->swap = 0;



		if (cros_ec_cmd_xfer_status(ec_dev, msg) < 0)

			break;



		p += scnprintf(p, sizeof(read_buf) + read_buf - p,

			       "p%d: %s en:%.2x role:%.2x pol:%.2x\n", i,

			       resp->state, resp->enabled, resp->role,

			       resp->polarity);

	}



	return simple_read_from_buffer(user_buf, count, ppos,

				       read_buf, p - read_buf);

}



const struct file_operations cros_ec_console_log_fops = {

	.owner = THIS_MODULE,

	.open = cros_ec_console_log_open,
@@ -220,6 +272,13 @@ const struct file_operations cros_ec_console_log_fops = { 
	.release = cros_ec_console_log_release,

};



const struct file_operations cros_ec_pdinfo_fops = {

	.owner = THIS_MODULE,

	.open = simple_open,

	.read = cros_ec_pdinfo_read,

	.llseek = default_llseek,

};



static int ec_read_version_supported(struct cros_ec_dev *ec)

{

	struct ec_params_get_cmd_versions_v1 *params;
@@ -355,6 +414,15 @@ static int cros_ec_create_panicinfo(struct cros_ec_debugfs *debug_info) 
	return ret;

}



static int cros_ec_create_pdinfo(struct cros_ec_debugfs *debug_info)

{

	if (!debugfs_create_file("pdinfo", 0444, debug_info->dir, debug_info,

				 &cros_ec_pdinfo_fops))

		return -ENOMEM;



	return 0;

}



int cros_ec_debugfs_init(struct cros_ec_dev *ec)

{

	struct cros_ec_platform *ec_platform = dev_get_platdata(ec->dev);
@@ -379,6 +447,10 @@ int cros_ec_debugfs_init(struct cros_ec_dev *ec) 
	if (ret)

		goto remove_debugfs;



	ret = cros_ec_create_pdinfo(debug_info);

	if (ret)

		goto remove_debugfs;



	ec->debug_info = debug_info;



	return 0;

include/linux/mfd/cros_ec_commands.h

+3 −0
Original line number Diff line number Diff line
@@ -2948,6 +2948,9 @@ struct ec_response_usb_pd_control_v1 { 


#define EC_CMD_USB_PD_PORTS 0x102



/* Maximum number of PD ports on a device, num_ports will be <= this */

#define EC_USB_PD_MAX_PORTS 8



struct ec_response_usb_pd_ports {

	uint8_t num_ports;

} __packed;