Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afbbc791 authored by Yoshihiro Shimoda's avatar Yoshihiro Shimoda Committed by Felipe Balbi
Browse files

usb: gadget: udc: renesas_usb3: Fix PN_INT_ENA disabling timing 



The PN_INT_ENA register should be used after usb3_pn_change() is called.
So, this patch moves the access from renesas_usb3_stop_controller() to
usb3_disable_pipe_n().

Fixes: 746bfe63 ("usb: gadget: renesas_usb3: add support for Renesas USB3.0 peripheral controller")
Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 940f538a

drivers/usb/gadget/udc/renesas_usb3.c

+1 −1
Original line number Diff line number Diff line
@@ -623,7 +623,6 @@ static void renesas_usb3_stop_controller(struct renesas_usb3 *usb3) 
{

	usb3_disconnect(usb3);

	usb3_write(usb3, 0, USB3_P0_INT_ENA);

	usb3_write(usb3, 0, USB3_PN_INT_ENA);

	usb3_write(usb3, 0, USB3_USB_OTG_INT_ENA);

	usb3_write(usb3, 0, USB3_USB_INT_ENA_1);

	usb3_write(usb3, 0, USB3_USB_INT_ENA_2);
@@ -1682,6 +1681,7 @@ static int usb3_disable_pipe_n(struct renesas_usb3_ep *usb3_ep) 


	spin_lock_irqsave(&usb3->lock, flags);

	if (!usb3_pn_change(usb3, usb3_ep->num)) {

		usb3_write(usb3, 0, USB3_PN_INT_ENA);

		usb3_write(usb3, 0, USB3_PN_RAMMAP);

		usb3_clear_bit(usb3, PN_CON_EN, USB3_PN_CON);

	}