Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afae457d authored by David Howells's avatar David Howells
Browse files

afs: Fix missing error handling in afs_write_end() 



afs_write_end() is missing page unlock and put if afs_fill_page() fails.

Reported-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
parent 440fbc3a

fs/afs/write.c

+5 −3
Original line number Diff line number Diff line
@@ -198,7 +198,7 @@ int afs_write_end(struct file *file, struct address_space *mapping, 
			ret = afs_fill_page(vnode, key, pos + copied,

					    len - copied, page);

			if (ret < 0)

				return ret;

				goto out;

		}

		SetPageUptodate(page);

	}
@@ -206,10 +206,12 @@ int afs_write_end(struct file *file, struct address_space *mapping, 
	set_page_dirty(page);

	if (PageDirty(page))

		_debug("dirtied");

	ret = copied;



out:

	unlock_page(page);

	put_page(page);



	return copied;

	return ret;

}



/*