Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af5cbc98 authored by Nimrod Andy's avatar Nimrod Andy Committed by David S. Miller
Browse files

net: fec: fix receive VLAN CTAG HW acceleration issue 



The current driver support receive VLAN CTAG HW acceleration feature
(NETIF_F_HW_VLAN_CTAG_RX) through software simulation. There calls the
api .skb_copy_to_linear_data_offset() to skip the VLAN tag, but there
have overlap between the two memory data point range. The patch just fix
the issue.

V2:
Michael Grzeschik suggest to use memmove() instead of skb_copy_to_linear_data_offset().

Reported-by: default avatarMichael Grzeschik <m.grzeschik@pengutronix.de>
Fixes: 1b7bde6d ("net: fec: implement rx_copybreak to improve rx performance")
Signed-off-by: default avatarFugang Duan <B38611@freescale.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5a3dba7a

drivers/net/ethernet/freescale/fec_main.c

+1 −2
Original line number Diff line number Diff line
@@ -1479,8 +1479,7 @@ fec_enet_rx_queue(struct net_device *ndev, int budget, u16 queue_id) 


			vlan_packet_rcvd = true;



			skb_copy_to_linear_data_offset(skb, VLAN_HLEN,

						       data, (2 * ETH_ALEN));

			memmove(skb->data + VLAN_HLEN, data, ETH_ALEN * 2);

			skb_pull(skb, VLAN_HLEN);

		}