Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af1f85dd authored by Alexandre Courbot's avatar Alexandre Courbot Committed by Alex Deucher
Browse files

drm/ttm: remove cpu_address member from ttm_tt 



Patch 3d50d4dc exposed the CPU address of DMA-allocated pages as
returned by dma_alloc_coherent because Nouveau on Tegra needed it.

This is not required anymore - as there were no other users for it,
remove it and save some memory for everyone.

Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Signed-off-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 0aa3e2d0

drivers/gpu/drm/ttm/ttm_page_alloc_dma.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -858,7 +858,6 @@ static int ttm_dma_pool_get_pages(struct dma_pool *pool, 
	if (count) {

	if (count) {

		d_page = list_first_entry(&pool->free_list, struct dma_page, page_list);

		d_page = list_first_entry(&pool->free_list, struct dma_page, page_list);

		ttm->pages[index] = d_page->p;

		ttm->pages[index] = d_page->p;

		ttm_dma->cpu_address[index] = d_page->vaddr;

		ttm_dma->dma_address[index] = d_page->dma;

		ttm_dma->dma_address[index] = d_page->dma;

		list_move_tail(&d_page->page_list, &ttm_dma->pages_list);

		list_move_tail(&d_page->page_list, &ttm_dma->pages_list);

		r = 0;

		r = 0;
@@ -989,7 +988,6 @@ void ttm_dma_unpopulate(struct ttm_dma_tt *ttm_dma, struct device *dev) 
	INIT_LIST_HEAD(&ttm_dma->pages_list);

	INIT_LIST_HEAD(&ttm_dma->pages_list);

	for (i = 0; i < ttm->num_pages; i++) {

	for (i = 0; i < ttm->num_pages; i++) {

		ttm->pages[i] = NULL;

		ttm->pages[i] = NULL;

		ttm_dma->cpu_address[i] = 0;

		ttm_dma->dma_address[i] = 0;

		ttm_dma->dma_address[i] = 0;

	}

	}

drivers/gpu/drm/ttm/ttm_tt.c

+2 −5
Original line number Original line Diff line number Diff line
@@ -57,10 +57,8 @@ static void ttm_dma_tt_alloc_page_directory(struct ttm_dma_tt *ttm) 
{

{

	ttm->ttm.pages = drm_calloc_large(ttm->ttm.num_pages,

	ttm->ttm.pages = drm_calloc_large(ttm->ttm.num_pages,

					  sizeof(*ttm->ttm.pages) +

					  sizeof(*ttm->ttm.pages) +

					  sizeof(*ttm->dma_address) +

					  sizeof(*ttm->dma_address));

					  sizeof(*ttm->cpu_address));

	ttm->dma_address = (void *) (ttm->ttm.pages + ttm->ttm.num_pages);

	ttm->cpu_address = (void *) (ttm->ttm.pages + ttm->ttm.num_pages);

	ttm->dma_address = (void *) (ttm->cpu_address + ttm->ttm.num_pages);

}

}





#ifdef CONFIG_X86

#ifdef CONFIG_X86
@@ -244,7 +242,6 @@ void ttm_dma_tt_fini(struct ttm_dma_tt *ttm_dma) 




	drm_free_large(ttm->pages);

	drm_free_large(ttm->pages);

	ttm->pages = NULL;

	ttm->pages = NULL;

	ttm_dma->cpu_address = NULL;

	ttm_dma->dma_address = NULL;

	ttm_dma->dma_address = NULL;

}

}

EXPORT_SYMBOL(ttm_dma_tt_fini);

EXPORT_SYMBOL(ttm_dma_tt_fini);

include/drm/ttm/ttm_bo_driver.h

+0 −2
Original line number Original line Diff line number Diff line
@@ -133,7 +133,6 @@ struct ttm_tt { 
 * struct ttm_dma_tt

 * struct ttm_dma_tt

 *

 *

 * @ttm: Base ttm_tt struct.

 * @ttm: Base ttm_tt struct.

 * @cpu_address: The CPU address of the pages

 * @dma_address: The DMA (bus) addresses of the pages

 * @dma_address: The DMA (bus) addresses of the pages

 * @pages_list: used by some page allocation backend

 * @pages_list: used by some page allocation backend

 *

 *
@@ -143,7 +142,6 @@ struct ttm_tt { 
 */

 */

struct ttm_dma_tt {

struct ttm_dma_tt {

	struct ttm_tt ttm;

	struct ttm_tt ttm;

	void **cpu_address;

	dma_addr_t *dma_address;

	dma_addr_t *dma_address;

	struct list_head pages_list;

	struct list_head pages_list;

};

};