Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit aefe207d authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman
Browse files

fs/ufs: avoid potential u32 multiplication overflow 



[ Upstream commit 88b2e9b06381551b707d980627ad0591191f7a2d ]

The 64 bit ino is being compared to the product of two u32 values,
however, the multiplication is being performed using a 32 bit multiply so
there is a potential of an overflow.  To be fully safe, cast uspi->s_ncg
to a u64 to ensure a 64 bit multiplication occurs to avoid any chance of
overflow.

Fixes: f3e2a520 ("ufs: NFS support")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Cc: Evgeniy Dushistov <dushistov@mail.ru>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Link: http://lkml.kernel.org/r/20200715170355.1081713-1-colin.king@canonical.com


Addresses-Coverity: ("Unintentional integer overflow")
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 9f3fb90d

fs/ufs/super.c

+1 −1
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ static struct inode *ufs_nfs_get_inode(struct super_block *sb, u64 ino, u32 gene 
	struct ufs_sb_private_info *uspi = UFS_SB(sb)->s_uspi;

	struct inode *inode;



	if (ino < UFS_ROOTINO || ino > uspi->s_ncg * uspi->s_ipg)

	if (ino < UFS_ROOTINO || ino > (u64)uspi->s_ncg * uspi->s_ipg)

		return ERR_PTR(-ESTALE);



	inode = ufs_iget(sb, ino);