Commit ae84b246 authored Feb 23, 2021 by Lee Duncan Committed by Greg Kroah-Hartman Mar 07, 2021

scsi: iscsi: Restrict sessions and handles to admin capabilities



commit 688e8128b7a92df982709a4137ea4588d16f24aa upstream.

Protect the iSCSI transport handle, available in sysfs, by requiring
CAP_SYS_ADMIN to read it. Also protect the netlink socket by restricting
reception of messages to ones sent with CAP_SYS_ADMIN. This disables
normal users from being able to end arbitrary iSCSI sessions.

Cc: stable@vger.kernel.org
Reported-by: Adam Nichols <adam@grimm-co.com>
Reviewed-by: Chris Leech <cleech@redhat.com>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4b2b6505

drivers/scsi/scsi_transport_iscsi.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -119,6 +119,9 @@ show_transport_handle(struct device dev, struct device_attribute attr,
		char *buf)
		{
		struct iscsi_internal *priv = dev_to_iscsi_internal(dev);

		if (!capable(CAP_SYS_ADMIN))
		return -EACCES;
		return sprintf(buf, "%llu\n", (unsigned long long)iscsi_handle(priv->iscsi_transport));
		}
		static DEVICE_ATTR(handle, S_IRUGO, show_transport_handle, NULL);
		@@ -3504,6 +3507,9 @@ iscsi_if_recv_msg(struct sk_buff skb, struct nlmsghdr nlh, uint32_t *group)
		struct iscsi_cls_conn *conn;
		struct iscsi_endpoint *ep = NULL;

		if (!netlink_capable(skb, CAP_SYS_ADMIN))
		return -EPERM;

		if (nlh->nlmsg_type == ISCSI_UEVENT_PATH_UPDATE)
		*group = ISCSI_NL_GRP_UIP;
		else