Commit ae7642bb authored Nov 13, 2005 by Peter Osterlund Committed by Linus Torvalds Nov 13, 2005

[PATCH] packet writing oops fix



There is an old bug in the pkt_count_states() function that causes stack
corruption.  When compiling with gcc 3.x or 2.x it is harmless, but gcc 4
allocates local variables differently, which makes the bug visible.

Signed-off-by: Peter Osterlund <petero2@telia.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 5563e770

drivers/block/pktcdvd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1188,7 +1188,7 @@ static void pkt_count_states(struct pktcdvd_device pd, int states)
		struct packet_data *pkt;
		int i;

		for (i = 0; i <= PACKET_NUM_STATES; i++)
		for (i = 0; i < PACKET_NUM_STATES; i++)
		states[i] = 0;

		spin_lock(&pd->cdrw.active_list_lock);