Commit ae6baa8c authored Feb 13, 2020 by Paul Cercueil Committed by Greg Kroah-Hartman Apr 17, 2020

clk: ingenic/jz4770: Exit with error if CGU init failed



commit c067b46d731a764fc46ecc466c2967088c97089e upstream.

Exit jz4770_cgu_init() if the 'cgu' pointer we get is NULL, since the
pointer is passed as argument to functions later on.

Fixes: 7a01c190 ("clk: Add Ingenic jz4770 CGU driver")
Cc: stable@vger.kernel.org
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lkml.kernel.org/r/20200213161952.37460-1-paul@crapouillou.net


Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent cdfa83e1

drivers/clk/ingenic/jz4770-cgu.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -436,8 +436,10 @@ static void __init jz4770_cgu_init(struct device_node *np)

	cgu = ingenic_cgu_new(jz4770_cgu_clocks,		cgu = ingenic_cgu_new(jz4770_cgu_clocks,
	ARRAY_SIZE(jz4770_cgu_clocks), np);		ARRAY_SIZE(jz4770_cgu_clocks), np);
	if (!cgu)		if (!cgu) {
	pr_err("%s: failed to initialise CGU\n", __func__);		pr_err("%s: failed to initialise CGU\n", __func__);
			return;
			}

	retval = ingenic_cgu_register_clocks(cgu);		retval = ingenic_cgu_register_clocks(cgu);
	if (retval)		if (retval)