Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adbe0da1 authored by Vijayanand Jitta's avatar Vijayanand Jitta
Browse files

iommu/iova: Free global iova rcache on iova alloc failure 



When ever an iova alloc request fails we free the iova
ranges present in the percpu iova rcaches and then retry
but the global iova rcache is not freed as a result we could
still see iova alloc failure even after retry as global
rcache is holding the iova's which can cause fragmentation.
So, free the global iova rcache as well and then go for the
retry.

Change-Id: Ib8236dc88ba5516b73d4fbf6bf8e68bbf09bbad2
Signed-off-by: default avatarVijayanand Jitta <vjitta@codeaurora.org>
parent 908dd550

drivers/iommu/iova.c

+23 −0
Original line number Diff line number Diff line
@@ -532,6 +532,7 @@ alloc_iova_fast(struct iova_domain *iovad, unsigned long size, 
		flush_rcache = false;

		for_each_online_cpu(cpu)

			free_cpu_cached_iovas(cpu, iovad);

		free_global_cached_iovas(iovad);

		goto retry;

	}
@@ -1145,5 +1146,27 @@ void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad) 
	}

}



/*

 * free all the IOVA ranges of global cache

 */

void free_global_cached_iovas(struct iova_domain *iovad)

{

	struct iova_rcache *rcache;

	unsigned long flags;

	int i, j;



	for (i = 0; i < IOVA_RANGE_CACHE_MAX_SIZE; ++i) {

		rcache = &iovad->rcaches[i];

		spin_lock_irqsave(&rcache->lock, flags);

		for (j = 0; j < rcache->depot_size; ++j) {

			iova_magazine_free_pfns(rcache->depot[j], iovad);

			iova_magazine_free(rcache->depot[j]);

			rcache->depot[j] = NULL;

		}

		rcache->depot_size = 0;

		spin_unlock_irqrestore(&rcache->lock, flags);

	}

}



MODULE_AUTHOR("Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>");

MODULE_LICENSE("GPL");

include/linux/iova.h

+6 −0
Original line number Diff line number Diff line
@@ -166,6 +166,7 @@ void put_iova_domain(struct iova_domain *iovad); 
struct iova *split_and_remove_iova(struct iova_domain *iovad,

	struct iova *iova, unsigned long pfn_lo, unsigned long pfn_hi);

void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad);

void free_global_cached_iovas(struct iova_domain *iovad);

#else

static inline int iova_cache_get(void)

{
@@ -273,6 +274,11 @@ static inline void free_cpu_cached_iovas(unsigned int cpu, 
					 struct iova_domain *iovad)

{

}



static inline void free_global_cached_iovas(struct iova_domain *iovad)

{

}



#endif



#endif