Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adb4b83c authored Mar 15, 2010 by Dan Carpenter Committed by Jason Wessel Mar 25, 2011

kgdboc,kgdbts: strlen() doesn't count the terminator



This is an off by one because strlen() doesn't count the null
terminator.  We strcpy() these strings into an array of size
MAX_CONFIG_LEN.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

parent 521cb40b

drivers/misc/kgdbts.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -988,7 +988,7 @@ static void kgdbts_run_tests(void)

		static int kgdbts_option_setup(char *opt)
		{
		if (strlen(opt) > MAX_CONFIG_LEN) {
		if (strlen(opt) >= MAX_CONFIG_LEN) {
		printk(KERN_ERR "kgdbts: config string too long\n");
		return -ENOSPC;
		}

drivers/tty/serial/kgdboc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -131,7 +131,7 @@ static void kgdboc_unregister_kbd(void)

		static int kgdboc_option_setup(char *opt)
		{
		if (strlen(opt) > MAX_CONFIG_LEN) {
		if (strlen(opt) >= MAX_CONFIG_LEN) {
		printk(KERN_ERR "kgdboc: config string too long\n");
		return -ENOSPC;
		}