Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit adb3d770 authored by Haneen Mohammed's avatar Haneen Mohammed Committed by Greg Kroah-Hartman
Browse files

Staging: rtl8188eu: Remove parentheses around right side an assignment 



Parentheses are not needed around the right hand side of an assignment.
This patch remove parenthese of such occurenses. Issue was detected and
solved using the following coccinelle script:

@rule1@
identifier x, y, z;
expression E1, E2;
@@

(
x = (y == z);
|
x = (E1 == E2);
|
 x =
-(
...
-)
 ;
)

Signed-off-by: default avatarHaneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e1cc3112

drivers/staging/rtl8188eu/core/rtw_efuse.c

+3 −3
Original line number Diff line number Diff line
@@ -150,12 +150,12 @@ efuse_phymap_to_logical(u8 *phymap, u16 _offset, u16 _size_byte, u8 *pbuf) 
				continue;

			} else {

				offset = ((rtemp8 & 0xF0) >> 1) | u1temp;

				wren = (rtemp8 & 0x0F);

				wren = rtemp8 & 0x0F;

				eFuse_Addr++;

			}

		} else {

			offset = ((rtemp8 >> 4) & 0x0f);

			wren = (rtemp8 & 0x0f);

			offset = (rtemp8 >> 4) & 0x0f;

			wren = rtemp8 & 0x0f;

		}



		if (offset < EFUSE_MAX_SECTION_88E) {

drivers/staging/rtl8188eu/core/rtw_ieee80211.c

+1 −1
Original line number Diff line number Diff line
@@ -663,7 +663,7 @@ int rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie, u16 *rsn_len, u8 *wpa_ie, 


	/* Search required WPA or WPA2 IE and copy to sec_ie[] */



	cnt = (_TIMESTAMP_ + _BEACON_ITERVAL_ + _CAPABILITY_);

	cnt = _TIMESTAMP_ + _BEACON_ITERVAL_ + _CAPABILITY_;



	sec_idx = 0;

drivers/staging/rtl8188eu/core/rtw_mlme.c

+1 −1
Original line number Diff line number Diff line
@@ -2042,7 +2042,7 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len) 
	p = rtw_get_ie(pie+sizeof(struct ndis_802_11_fixed_ie), _HT_CAPABILITY_IE_, &len, ie_len-sizeof(struct ndis_802_11_fixed_ie));

	if (p && len > 0) {

		pht_capie = (struct rtw_ieee80211_ht_cap *)(p+2);

		max_ampdu_sz = (pht_capie->ampdu_params_info & IEEE80211_HT_CAP_AMPDU_FACTOR);

		max_ampdu_sz = pht_capie->ampdu_params_info & IEEE80211_HT_CAP_AMPDU_FACTOR;

		max_ampdu_sz = 1 << (max_ampdu_sz+3); /*  max_ampdu_sz (kbytes); */

		phtpriv->rx_ampdu_maxlen = max_ampdu_sz;

	}

drivers/staging/rtl8188eu/core/rtw_mlme_ext.c

+11 −11
Original line number Diff line number Diff line
@@ -1639,7 +1639,7 @@ unsigned int OnAction_back(struct adapter *padapter, struct recv_frame *precv_fr 
			break;

		case RTW_WLAN_ACTION_ADDBA_RESP: /* ADDBA response */

			status = get_unaligned_le16(&frame_body[3]);

			tid = ((frame_body[5] >> 2) & 0x7);

			tid = (frame_body[5] >> 2) & 0x7;

			if (status == 0) {	/* successful */

				DBG_88E("agg_enable for TID=%d\n", tid);

				psta->htpriv.agg_enable_bitmap |= 1 << tid;
@@ -2491,7 +2491,7 @@ void issue_auth(struct adapter *padapter, struct sta_info *psta, unsigned short 


		/* setting IV for auth seq #3 */

		if ((pmlmeinfo->auth_seq == 3) && (pmlmeinfo->state & WIFI_FW_AUTH_STATE) && (use_shared_key == 1)) {

			val32 = ((pmlmeinfo->iv++) | (pmlmeinfo->key_index << 30));

			val32 = (pmlmeinfo->iv++) | (pmlmeinfo->key_index << 30);

			le_tmp32 = cpu_to_le32(val32);

			pframe = rtw_set_fixed_ie(pframe, 4, (unsigned char *)&le_tmp32, &(pattrib->pktlen));
@@ -3331,7 +3331,7 @@ void issue_action_BA(struct adapter *padapter, unsigned char *raddr, unsigned ch 
			} while (pmlmeinfo->dialogToken == 0);

			pframe = rtw_set_fixed_ie(pframe, 1, &(pmlmeinfo->dialogToken), &(pattrib->pktlen));



			BA_para_set = (0x1002 | ((status & 0xf) << 2)); /* immediate ack & 64 buffer size */

			BA_para_set = 0x1002 | ((status & 0xf) << 2); /* immediate ack & 64 buffer size */

			le_tmp = cpu_to_le16(BA_para_set);

			pframe = rtw_set_fixed_ie(pframe, 2, (unsigned char *)(&(le_tmp)), &(pattrib->pktlen));
@@ -4247,7 +4247,7 @@ void report_survey_event(struct adapter *padapter, 
	if (pcmd_obj == NULL)

		return;



	cmdsz = (sizeof(struct survey_event) + sizeof(struct C2HEvent_Header));

	cmdsz = sizeof(struct survey_event) + sizeof(struct C2HEvent_Header);

	pevtcmd = kzalloc(cmdsz, GFP_ATOMIC);

	if (pevtcmd == NULL) {

		kfree(pcmd_obj);
@@ -4299,7 +4299,7 @@ void report_surveydone_event(struct adapter *padapter) 
	if (pcmd_obj == NULL)

		return;



	cmdsz = (sizeof(struct surveydone_event) + sizeof(struct C2HEvent_Header));

	cmdsz = sizeof(struct surveydone_event) + sizeof(struct C2HEvent_Header);

	pevtcmd = kzalloc(cmdsz, GFP_KERNEL);

	if (pevtcmd == NULL) {

		kfree(pcmd_obj);
@@ -4345,7 +4345,7 @@ void report_join_res(struct adapter *padapter, int res) 
	if (pcmd_obj == NULL)

		return;



	cmdsz = (sizeof(struct joinbss_event) + sizeof(struct C2HEvent_Header));

	cmdsz = sizeof(struct joinbss_event) + sizeof(struct C2HEvent_Header);

	pevtcmd = kzalloc(cmdsz, GFP_ATOMIC);

	if (pevtcmd == NULL) {

		kfree(pcmd_obj);
@@ -4398,7 +4398,7 @@ void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsi 
	if (pcmd_obj == NULL)

		return;



	cmdsz = (sizeof(struct stadel_event) + sizeof(struct C2HEvent_Header));

	cmdsz = sizeof(struct stadel_event) + sizeof(struct C2HEvent_Header);

	pevtcmd = kzalloc(cmdsz, GFP_KERNEL);

	if (pevtcmd == NULL) {

		kfree(pcmd_obj);
@@ -4428,7 +4428,7 @@ void report_del_sta_event(struct adapter *padapter, unsigned char *MacAddr, unsi 
	if (psta)

		mac_id = (int)psta->mac_id;

	else

		mac_id = (-1);

		mac_id = -1;



	pdel_sta_evt->mac_id = mac_id;
@@ -4453,7 +4453,7 @@ void report_add_sta_event(struct adapter *padapter, unsigned char *MacAddr, int 
	if (pcmd_obj == NULL)

		return;



	cmdsz = (sizeof(struct stassoc_event) + sizeof(struct C2HEvent_Header));

	cmdsz = sizeof(struct stassoc_event) + sizeof(struct C2HEvent_Header);

	pevtcmd = kzalloc(cmdsz, GFP_KERNEL);

	if (pevtcmd == NULL) {

		kfree(pcmd_obj);
@@ -5356,7 +5356,7 @@ u8 set_stakey_hdl(struct adapter *padapter, u8 *pbuf) 


		psta = rtw_get_stainfo(pstapriv, pparm->addr);

		if (psta) {

			ctrl = (BIT(15) | ((pparm->algorithm) << 2));

			ctrl = BIT(15) | ((pparm->algorithm) << 2);



			DBG_88E("r871x_set_stakey_hdl(): enc_algorithm=%d\n", pparm->algorithm);
@@ -5365,7 +5365,7 @@ u8 set_stakey_hdl(struct adapter *padapter, u8 *pbuf) 
				return H2C_REJECTED;

			}



			cam_id = (psta->mac_id + 3);/* 0~3 for default key, cmd_id = macid + 3, macid = aid+1; */

			cam_id = psta->mac_id + 3;/* 0~3 for default key, cmd_id = macid + 3, macid = aid+1; */



			DBG_88E("Write CAM, mac_addr =%x:%x:%x:%x:%x:%x, cam_entry=%d\n", pparm->addr[0],

				pparm->addr[1], pparm->addr[2], pparm->addr[3], pparm->addr[4],

drivers/staging/rtl8188eu/core/rtw_recv.c

+2 −2
Original line number Diff line number Diff line
@@ -2163,7 +2163,7 @@ void rtw_signal_stat_timer_hdl(unsigned long data) 


		/* update value of signal_strength, rssi, signal_qual */

		if (check_fwstate(&adapter->mlmepriv, _FW_UNDER_SURVEY) == false) {

			tmp_s = (avg_signal_strength+(_alpha-1)*recvpriv->signal_strength);

			tmp_s = avg_signal_strength+(_alpha-1)*recvpriv->signal_strength;

			if (tmp_s % _alpha)

				tmp_s = tmp_s/_alpha + 1;

			else
@@ -2171,7 +2171,7 @@ void rtw_signal_stat_timer_hdl(unsigned long data) 
			if (tmp_s > 100)

				tmp_s = 100;



			tmp_q = (avg_signal_qual+(_alpha-1)*recvpriv->signal_qual);

			tmp_q = avg_signal_qual+(_alpha-1)*recvpriv->signal_qual;

			if (tmp_q % _alpha)

				tmp_q = tmp_q/_alpha + 1;

			else