Commit ad6a0f23 authored May 03, 2021 by Alaa Emad Committed by Greg Kroah-Hartman Jun 03, 2021

media: dvb: Add check on sp8870_readreg return



[ Upstream commit c6d822c56e7fd29e6fa1b1bb91b98f6a1e942b3c ]

The function sp8870_readreg returns a negative value when i2c_transfer
fails so properly check for this and return the error if it happens.

Cc: Sean Young <sean@mess.org>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Alaa Emad <alaaemadhossney.ae@gmail.com>
Link: https://lore.kernel.org/r/20210503115736.2104747-60-gregkh@linuxfoundation.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9f1b3a5e

drivers/media/dvb-frontends/sp8870.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -293,7 +293,9 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe)
		sp8870_writereg(state, 0xc05, reg0xc05);

		// read status reg in order to clear pending irqs
		sp8870_readreg(state, 0x200);
		err = sp8870_readreg(state, 0x200);
		if (err < 0)
		return err;

		// system controller start
		sp8870_microcontroller_start(state);