Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ad5fa025 authored by Joe Carnuccio's avatar Joe Carnuccio Committed by James Bottomley
Browse files

[SCSI] qla2xxx: Fix undefined behavior in call to snprintf(). 



Signed-off-by: default avatarJoe Carnuccio <joe.carnuccio@qlogic.com>
Signed-off-by: default avatarSaurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent db64e930

drivers/scsi/qla2xxx/qla_attr.c

+2 −2
Original line number Diff line number Diff line
@@ -917,8 +917,8 @@ qla2x00_serial_num_show(struct device *dev, struct device_attribute *attr, 
		return snprintf(buf, PAGE_SIZE, "%s\n",

		    vha->hw->mr.serial_num);

	} else if (IS_FWI2_CAPABLE(ha)) {

		qla2xxx_get_vpd_field(vha, "SN", buf, PAGE_SIZE);

		return snprintf(buf, PAGE_SIZE, "%s\n", buf);

		qla2xxx_get_vpd_field(vha, "SN", buf, PAGE_SIZE - 1);

		return strlen(strcat(buf, "\n"));

	}



	sn = ((ha->serial0 & 0x1f) << 16) | (ha->serial2 << 8) | ha->serial1;