Commit ad535807 authored Mar 12, 2020 by Marco Felsch Committed by Greg Kroah-Hartman Sep 23, 2023

media: v4l2-fwnode: fix v4l2_fwnode_parse_link handling

[ Upstream commit 453b0c8304dcbc6eed2836de8fee90bf5bcc7006 ]

Currently the driver differentiate the port number property handling for
ACPI and DT. This is wrong as because ACPI should use the "reg" val too
[1].

[1] https://patchwork.kernel.org/patch/11421985/



Fixes: ca50c197 ("[media] v4l: fwnode: Support generic fwnode for parsing standardised properties")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Stable-dep-of: d7b13edd4cb4 ("media: v4l2-core: Fix a potential resource leak in v4l2_fwnode_parse_link()")
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 41626db5

drivers/media/v4l2-core/v4l2-fwnode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -282,7 +282,7 @@ EXPORT_SYMBOL_GPL(v4l2_fwnode_endpoint_alloc_parse);
		int v4l2_fwnode_parse_link(struct fwnode_handle *__fwnode,
		struct v4l2_fwnode_link *link)
		{
		const char *port_prop = is_of_node(__fwnode) ? "reg" : "port";
		const char *port_prop = "reg";
		struct fwnode_handle *fwnode;

		memset(link, 0, sizeof(*link));